Skip to content

feat: Triple Rest OpenAPI Support#3280

Open
eye-gu wants to merge 8 commits intoapache:developfrom
eye-gu:fix-2842-triple-openapi
Open

feat: Triple Rest OpenAPI Support#3280
eye-gu wants to merge 8 commits intoapache:developfrom
eye-gu:fix-2842-triple-openapi

Conversation

@eye-gu
Copy link
Copy Markdown

@eye-gu eye-gu commented Mar 25, 2026

Description

Fixes #2842

Checklist

  • I confirm the target branch is develop
  • Code has passed local testing
  • I have added tests that prove my fix is effective or that my feature works

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 54.92142% with 545 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.66%. Comparing base (60d1c2a) to head (7be739e).
⚠️ Report is 767 commits behind head on develop.

Files with missing lines Patch % Lines
protocol/triple/openapi/model/openapi.go 0.00% 105 Missing ⚠️
protocol/triple/openapi/swagger_ui_handler.go 0.00% 97 Missing ⚠️
protocol/triple/openapi/redoc_handler.go 0.00% 49 Missing ⚠️
protocol/triple/openapi/model/schema.go 0.00% 41 Missing ⚠️
protocol/triple/openapi/integration.go 0.00% 40 Missing ⚠️
protocol/triple/options.go 0.00% 36 Missing ⚠️
protocol/triple/openapi/model/operation.go 0.00% 24 Missing ⚠️
protocol/triple/server.go 37.14% 21 Missing and 1 partial ⚠️
protocol/triple/openapi/definition_resolver.go 86.17% 12 Missing and 5 partials ⚠️
protocol/triple/openapi/model/request.go 0.00% 17 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3280      +/-   ##
===========================================
+ Coverage    46.76%   49.66%   +2.89%     
===========================================
  Files          295      484     +189     
  Lines        17172    35802   +18630     
===========================================
+ Hits          8031    17781    +9750     
- Misses        8287    16611    +8324     
- Partials       854     1410     +556     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Alanxtl Alanxtl linked an issue Mar 26, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@Alanxtl Alanxtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool work, but I still have few comments

  1. pls write thorough test for this feature
  2. pls write use sample(integrate test) of this feature in dubbo-go-samples
  3. pls write doc to demonstrate the usage of this feature in dubbo-website

@Alanxtl
Copy link
Copy Markdown
Contributor

Alanxtl commented Mar 26, 2026

@zbchi @CAICAIIs @Aetherance @Similarityoung @nanjiek pls help review this pr

@eye-gu
Copy link
Copy Markdown
Author

eye-gu commented Apr 8, 2026

cool work, but I still have few comments

  1. pls write thorough test for this feature
  2. pls write use sample(integrate test) of this feature in dubbo-go-samples
  3. pls write doc to demonstrate the usage of this feature in dubbo-website

Added some tests.
Added integrate test:apache/dubbo-go-samples#1063.
Added doc: apache/dubbo-website#3203

Copy link
Copy Markdown
Contributor

@Alanxtl Alanxtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CAICAIIs
Copy link
Copy Markdown
Contributor

CAICAIIs commented Apr 8, 2026

And if you confirm that a problem has been resolved, you can click Resolve conversation

@eye-gu
Copy link
Copy Markdown
Author

eye-gu commented Apr 8, 2026

And if you confirm that a problem has been resolved, you can click Resolve conversation

Got it. I thought it was supposed to be closed by the reviewer.

Copy link
Copy Markdown
Member

@No-SilverBullet No-SilverBullet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, LGTM :) 👍

Copy link
Copy Markdown
Contributor

@CAICAIIs CAICAIIs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triple Rest OpenAPI Support

9 participants