-
Notifications
You must be signed in to change notification settings - Fork 998
feat(probe): add Kubernetes probe support with liveness, readiness, and startup checks #3213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9f37c8d
feat(probe): add Kubernetes probe support with liveness, readiness, a…
Alanxtl cb2cdae
import format
Alanxtl 62f7127
delete useless test
Alanxtl 53a5f19
import format
Alanxtl 87ba06f
fix comments
Alanxtl ae06411
fix ci
Alanxtl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package probe | ||
|
|
||
| import ( | ||
| "errors" | ||
| "net/http" | ||
| ) | ||
|
|
||
| var ( | ||
| errNotReady = errors.New("not ready") | ||
| errNotStarted = errors.New("not started") | ||
| ) | ||
|
|
||
| func livenessHandler(w http.ResponseWriter, r *http.Request) { | ||
| // k8s only use GET | ||
| if r.Method != http.MethodGet { | ||
| http.Error(w, "method not allowed", http.StatusMethodNotAllowed) | ||
|
Check failure on line 33 in metrics/probe/http.go
|
||
| return | ||
| } | ||
|
|
||
| if err := CheckLiveness(r.Context()); err != nil { | ||
| http.Error(w, err.Error(), http.StatusServiceUnavailable) | ||
| return | ||
| } | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte("ok")) | ||
| } | ||
|
|
||
| func readinessHandler(w http.ResponseWriter, r *http.Request) { | ||
| // k8s only use GET | ||
| if r.Method != http.MethodGet { | ||
| http.Error(w, "method not allowed", http.StatusMethodNotAllowed) | ||
| return | ||
| } | ||
|
|
||
| if err := CheckReadiness(r.Context()); err != nil { | ||
| http.Error(w, err.Error(), http.StatusServiceUnavailable) | ||
| return | ||
| } | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte("ok")) | ||
| } | ||
|
|
||
| func startupHandler(w http.ResponseWriter, r *http.Request) { | ||
| // k8s only use GET | ||
| if r.Method != http.MethodGet { | ||
| http.Error(w, "method not allowed", http.StatusMethodNotAllowed) | ||
| return | ||
| } | ||
|
|
||
| if err := CheckStartup(r.Context()); err != nil { | ||
| http.Error(w, err.Error(), http.StatusServiceUnavailable) | ||
| return | ||
| } | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte("ok")) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package probe | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestHandlersSuccess(t *testing.T) { | ||
| resetProbeState() | ||
|
|
||
| RegisterLiveness("ok", func(context.Context) error { return nil }) | ||
| RegisterReadiness("ok", func(context.Context) error { return nil }) | ||
| RegisterStartup("ok", func(context.Context) error { return nil }) | ||
|
|
||
| req := httptest.NewRequest(http.MethodGet, "/live", nil) | ||
| rec := httptest.NewRecorder() | ||
| livenessHandler(rec, req) | ||
| if rec.Code != http.StatusOK { | ||
| t.Fatalf("expected 200 for liveness, got %d", rec.Code) | ||
| } | ||
|
|
||
| req = httptest.NewRequest(http.MethodGet, "/ready", nil) | ||
| rec = httptest.NewRecorder() | ||
| readinessHandler(rec, req) | ||
| if rec.Code != http.StatusOK { | ||
| t.Fatalf("expected 200 for readiness, got %d", rec.Code) | ||
| } | ||
|
|
||
| req = httptest.NewRequest(http.MethodGet, "/startup", nil) | ||
| rec = httptest.NewRecorder() | ||
| startupHandler(rec, req) | ||
| if rec.Code != http.StatusOK { | ||
| t.Fatalf("expected 200 for startup, got %d", rec.Code) | ||
| } | ||
| } | ||
|
|
||
| func TestHandlersFailure(t *testing.T) { | ||
| resetProbeState() | ||
|
|
||
| RegisterLiveness("fail", func(context.Context) error { return errors.New("bad") }) | ||
| RegisterReadiness("fail", func(context.Context) error { return errors.New("bad") }) | ||
| RegisterStartup("fail", func(context.Context) error { return errors.New("bad") }) | ||
|
|
||
| req := httptest.NewRequest(http.MethodGet, "/live", nil) | ||
| rec := httptest.NewRecorder() | ||
| livenessHandler(rec, req) | ||
| if rec.Code != http.StatusServiceUnavailable { | ||
| t.Fatalf("expected 503 for liveness, got %d", rec.Code) | ||
| } | ||
|
|
||
| req = httptest.NewRequest(http.MethodGet, "/ready", nil) | ||
| rec = httptest.NewRecorder() | ||
| readinessHandler(rec, req) | ||
| if rec.Code != http.StatusServiceUnavailable { | ||
| t.Fatalf("expected 503 for readiness, got %d", rec.Code) | ||
| } | ||
|
|
||
| req = httptest.NewRequest(http.MethodGet, "/startup", nil) | ||
| rec = httptest.NewRecorder() | ||
| startupHandler(rec, req) | ||
| if rec.Code != http.StatusServiceUnavailable { | ||
| t.Fatalf("expected 503 for startup, got %d", rec.Code) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.