[fix](regression) Wait row count before hot value analyze#63758
Merged
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: The hot value analyze regression test can run sample analyze before Cloud table row count metadata is reported. In that state sample analyze treats the table as empty and writes empty column statistics, making the test flaky. Wait for SHOW DATA to report the inserted row count before running analyze on non-empty test tables.
### Release note
None
### Check List (For Author)
- Test: Regression test
- ./build.sh --fe
- ./run-regression-test.sh --run -d statistics -s test_full_analyze_hot_value
- git diff --check
- Behavior changed: No
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
hello-stephen
approved these changes
May 28, 2026
Contributor
|
/review |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
There was a problem hiding this comment.
Review result: no blocking issues found.
Critical checkpoint conclusions:
- Goal and proof: The PR addresses a flaky hot-value analyze regression by waiting until FE metadata reports the inserted row count before running analyze. The added waits cover each non-empty table introduced before analyze, and the existing regression test is the proof target.
- Scope: The change is small and focused on the affected regression suite. It follows an existing helper pattern used by other statistics tests.
- Concurrency/lifecycle: No product concurrency or lifecycle changes. The polling loop only waits for asynchronously reported row-count metadata in test execution.
- Configuration/compatibility: No new configs, protocol, storage, or compatibility changes.
- Parallel paths: Existing statistics tests already use similar
SHOW DATA/master-FE polling; this PR applies the same approach to the missing hot-value suite. - Tests/results: The PR modifies only a regression test and reports
./run-regression-test.sh --run -d statistics -s test_full_analyze_hot_value. I did not rerun tests in this review. - Observability/performance: Test-only logging and polling are acceptable for this regression context; no runtime observability or performance impact.
- Transactions/persistence/data writes: No product transaction or persistence path changes.
- User focus: No additional user-provided review focus was specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
The hot value analyze regression test can run sample analyze before Cloud table row count metadata is reported. In that state sample analyze treats the table as empty and writes empty column statistics, making the test flaky. This PR waits for SHOW DATA to report the inserted row count before running analyze on non-empty test tables.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)
Tests: