fix: clear handled OFFSET before child recursion in LimitPushdown#22525
Open
kumarUjjawal wants to merge 1 commit into
Open
fix: clear handled OFFSET before child recursion in LimitPushdown#22525kumarUjjawal wants to merge 1 commit into
kumarUjjawal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
LimitPushdowncarriesGlobalRequirementswhile walking the physical plan.In the bad plan shape from #22489, an outer
OFFSETwas already handled abovea sort barrier, but its
skipstill remained in the state when recursioncontinued into the child subtree. That stale
skipthen merged with an innerLIMITand reduced its fetch incorrectly, which caused a grouped row to bedropped.
The fix is to clear
skiponce the limit requirement has already been handled,while keeping
fetchso valid limit pushdown into child sorts still happens.What changes are included in this PR?
skipbefore recursing into children when the limit requirement is already handled.fetchunchanged so valid TopK-style pushdown still works.OFFSET/ sort barrier / innerLIMITshape.Are these changes tested?
Yes
Are there any user-facing changes?
No API Change