feat: ShuffleReader shows upstream_stage#1767
Merged
Merged
Conversation
Contributor
Author
|
if you have no big issues with this pr will merge it as soon as ci green, as provided info is needed for #1752, thanks @andygrove @martin-g |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Reading stage plans can sometimes be difficult, particularly for more complex ones. It’s especially tricky to determine which stage generated shuffle files for current
ShuffleReader.This came obvious debugging issues in #1752
What changes are included in this PR?
ShuffleReader prints
upstream_stageas part of plan, making life easier if plan debug is needed,ShuffleReaderalready keeps upstream stage id, so this change will only change display part.Are there any user-facing changes?
No. Test can be affected as EXPLAIN format has been changed