docs(release): cover TestPyPI verification and fix stale wheel-download notes#1760
Merged
Merged
Conversation
…ad notes - Add a 'Verify the Python wheels from TestPyPI' subsection under Verifying Release Candidates so RC verifiers can install from test.pypi.org if the release manager has done the pre-vote dry-run. - Document that download-python-wheels.py needs an interactive terminal for gpg signing; the wheels download fine before the signing step, so a TestPyPI-only dry-run can ignore the traceback. - Replace the manylinux_2_17 wheel filenames in the expected-files list with glibc-version-agnostic globs; the runner images advance their glibc tag. - Drop the 'build-sdist does not upload its output' warning (made stale by apache#1753) and fix the local-rebuild fallback to use 'maturin sdist' instead of the broken 'maturin build --release --sdist' (fixed in apache#1759, which produced both a wheel and an sdist). - Refresh the per-platform fallback artifact names: dist-windows-2022 (apache#1751) and the new dist-sdist artifact. - Note that the smoke-test venv needs Python >= 3.10; macOS's stock python3 (3.9) yields a misleading 'No matching distribution' error against the cp310-abi3 wheels.
martin-g
reviewed
May 25, 2026
| --extra-index-url https://pypi.org/simple/ \ | ||
| ballista==${BALLISTA_VERSION} | ||
| python -c "from ballista import BallistaSessionContext; print('ok')" | ||
| deactivate |
Member
There was a problem hiding this comment.
Is it expected/guaranteed that the new version will be at test.pypi.org ?
If the release manager always uploads the wheel to test.pypi.org then this snippet could be added to dev/release/verify-release-candidate.sh and done automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Worked through the Python wheel release docs end-to-end on the
53.0.0-rc1-pypitest-3tag and hit a few rough edges and stale pieces:dev/release/download-python-wheels.pyaborts in non-interactive shells because the gpg signing step needs a TTY for pinentry. There is no warning in the docs and the failure mode is confusing.manylinux_2_17glibc tag, but the runner image now producesmanylinux_2_39wheels (and that number will keep moving as the GitHub-hosted runner advances).build-sdistjob currently does not upload its output as a workflow artifact." That is no longer true after ci: produce real aarch64 wheel and upload sdist artifact #1753, which added adist-sdistartifact. The local-rebuild command in that same block usesmaturin build --release --sdist --out dist, which was the broken command (it produces both a wheel and an sdist) fixed in ci: use maturin sdist subcommand to avoid building a wheel #1759.dist-windows-latest, but ci: pin Windows wheel builder to windows-2022 #1751 renamed it todist-windows-2022. It also omits the newdist-sdist.python -m venvagainst whateverpythonis on PATH. On macOS that is 3.9, and pip then reports a misleading "No matching distribution found" because the wheels arecp310-abi3(Python ≥ 3.10).What changes are included in this PR?
dev/release/README.mdonly:download-python-wheels.pyexplaining the gpg/non-TTY failure mode and that the traceback is harmless for a TestPyPI-only dry-run.manylinux_*globs instead of the hard-codedmanylinux_2_17tag, with a one-line explanation of why.gh run downloadaddsdist-sdistand renamesdist-windows-latest→dist-windows-2022.maturin sdist --out distcommand.python3.10and a comment explains whypythonalone is not enough.No code, script, or workflow changes.
Are there any user-facing changes?
Documentation only. No runtime or API impact.