ci: gate Rust workflow on workspace path allow list and rename to Ballista Rust#1757
Merged
Merged
Conversation
…lista Rust The Rust workflow runs the full Linux/macOS/Windows test matrix plus clippy, rustdoc, fmt, and benchmark verification. It currently uses a `paths-ignore` deny list that only excludes docs and Markdown, so Python-only PRs (the `python/` crate is excluded from the Cargo workspace) still trigger the whole matrix. Switch to an explicit `paths` allow list scoped to the workspace crates, root manifests, the pinned toolchain, the `ci/scripts/` helpers used by the lint jobs, the reusable setup-builder actions, and the workflow itself. Also rename the workflow from `Rust` to `Ballista Rust` so it stands out from the core DataFusion Rust workflow in the ASF GitHub runner usage charts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of apache/datafusion#22455.
Rationale for this change
rust.ymlis the heaviest CI workflow in the repo: full Linux/macOS/Windows test matrix plus clippy, rustdoc, fmt, benchmark verification, and Cargo.toml format checks. It currently uses apaths-ignoredeny list that only excludes docs and Markdown, so changes to thepython/crate (which is excluded from the Cargo workspace) still trigger the whole matrix even though they cannot affect any of these jobs.Additionally, the workflow is named just
Rust, which is indistinguishable from the core DataFusionRustworkflow when looking at the ASF GitHub runner usage dashboards.What changes are included in this PR?
pushandpull_requesttriggers frompaths-ignoreto apathsallow list scoped to what the workflow actually consumes:ballista/**,ballista-cli/**,benchmarks/**,examples/**Cargo.toml,Cargo.lockrust-toolchain.tomlci/scripts/**— used by the lint, clippy, rustdoc, and tomlfmt jobssetup-builder,setup-macos-builder,setup-windows-builder,setup-rust-runtimeRusttoBallista Rustso it is distinguishable from the core DataFusion Rust workflow in shared ASF runner-usage charts.Are there any user-facing changes?
The workflow's display name in GitHub Actions UIs and required-check lists changes from
RusttoBallista Rust. Branch protection rules that reference the old name by string will need to be updated.