feat(AQE): empty join handling#1723
Open
sandugood wants to merge 6 commits into
Open
Conversation
Contributor
|
thanks @sandugood will have a look soon |
milenkovicm
reviewed
May 27, 2026
Contributor
There was a problem hiding this comment.
sorry for late review @sandugood
few recommendations
this is extra on top of your current contribution that would make sense to be added, please add it.
empty_exec! should produce correct partition num
macro_rules! empty_exec {
($e:expr) => {
Ok(Transformed::yes(Arc::new(
EmptyExec::new($e.schema())
.with_partitions($e.properties().output_partitioning().partition_count()),
)))
};
}
add configuration value
ballista.planner.propagate_empty.enabled=true as we may need to disable this rule in some cases
Contributor
|
#1752 has few other rules added, could you please copy paste them here. Will merge this pr before that one and makes sense to include them |
Contributor
Author
|
Seems like there is an error when trying to get packages from crates.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Handles #1359, particularly this part:
Rationale for this change
Handling cases of different physical types of joins and adding branching for different logical parts (i.e Left or LeftAnti) without adding separate AQE rule - adding logic straight into the
PropagateEmptyExecRuleWhat changes are included in this PR?
JoinInfostruct to contain information about the join (both left and right part)as_joinfunction, which can be extended in the future to add support for other physical joins. Right now it handles both SortMerge and HashJoinis_guaranteed_emptyfrom the Spice-AI implementation of eliminating empty joins.Are there any user-facing changes?
No
Were this changes tested?
Yes, tests were included in both
propagate_empty.rsandjoin_info.rs