Replace ParseError with MultiException in FuzzData#1634
Merged
olabusayoT merged 1 commit intoapache:mainfrom Mar 4, 2026
Merged
Replace ParseError with MultiException in FuzzData#1634olabusayoT merged 1 commit intoapache:mainfrom
ParseError with MultiException in FuzzData#1634olabusayoT merged 1 commit intoapache:mainfrom
Conversation
olabusayoT
force-pushed
the
daf-3075-fix-catch
branch
2 times, most recently
from
cbe1212 to
49b510f
Compare
stevedlawrence
approved these changes
Feb 25, 2026
| } catch { | ||
| case p: ParseError => { | ||
| handleParseError(p, testData, i) | ||
| case p: MultiException[Throwable] @unchecked => { |
Member
There was a problem hiding this comment.
Does this need to be marked as unchecked?
Contributor
Author
There was a problem hiding this comment.
Yes the compiler complains otherwise
|
|
||
| var shouldFail = false | ||
|
|
||
| override def handleParseError(p: ParseError, data: Array[Byte], nth: Int): Unit = { |
Member
There was a problem hiding this comment.
Is it worth changing the argument names from p to ex or something to better match what the argument represents?
- Consolidated exception handling under `handleKnownException` to manage both `MultiException` and `ParseError`. This is because MultiException.toss can throw either a ParseError or a MultiException - Adjusted related method and variable names for consistency. DAFFODIL-3075
olabusayoT
force-pushed
the
daf-3075-fix-catch
branch
from
6ecff5b to
34982b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultiException, replacing the olderParseErrorusage across methods inFuzzData.scala.DAFFODIL-3075