Skip to content

fix: enable infoset and infoset-diff views from any file context during debugging#1704

Open
social5h3ll wants to merge 1 commit into
apache:mainfrom
social5h3ll:fix/enable-infoset-commands-from-daffodil-helper
Open

fix: enable infoset and infoset-diff views from any file context during debugging#1704
social5h3ll wants to merge 1 commit into
apache:mainfrom
social5h3ll:fix/enable-infoset-commands-from-daffodil-helper

Conversation

@social5h3ll
Copy link
Copy Markdown

Fixes: #1703

Problem

While parsing a file, the Daffodil helper tab does not list the option to open the Infoset or Infoset Diff View unless the active tab is the DFDL schema file. This is because the infoset.display and infoset.diff commands are gated by editorLangId == 'dfdl' — they only appear when a DFDL schema file is the active editor.

This means if a user is debugging and switches to a data file or any other file type, they cannot access the infoset views from the Daffodil helper.

Root Cause

In package.json, the command enablement and menu when clauses both included editorLangId == 'dfdl':

"enablement": "inDebugMode && editorLangId == 'dfdl'"
"when": "inDebugMode && editorLangId == 'dfdl'"

This condition restricts the infoset commands to DFDL schema editors only, even though the infoset data is available throughout the debug session.

Fix

Remove && editorLangId == 'dfdl' from both the enablement field and the editor/title menu when clause for both infoset.display and infoset.diff commands.

After the fix:

  • enablement: inDebugMode
  • when: inDebugMode

This keeps the commands available only during active debug sessions but removes the schema-file-only restriction, so users can open the infoset views from any file context while debugging.

Acceptance Criteria

  • Infoset view command available from Daffodil helper during debugging regardless of active file type
  • Infoset diff view command available from Daffodil helper during debugging regardless of active file type
  • Commands remain gated by inDebugMode (not available outside debug sessions)

Closes #1703

…ng debugging

Currently 'Display the infoset view' and 'View infoset diff' commands are
only enabled when the active editor is a DFDL schema file
(`editorLangId == 'dfdl'`). This prevents users from opening the infoset
or infoset-diff views via the Daffodil helper tab when the active file is
not the schema file.

Fix: remove the `editorLangId == 'dfdl'` condition from both the
`enablement` field in commands and the `when` clause in
`editor/title` menu, so the buttons are available whenever a debug
session is active.

Closes apache#1703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to open infoset or infoset-diff-view from Daffodil helper tab

1 participant