allow uuid being created and managed by kubernetes#73
Closed
colearendt wants to merge 3 commits intoapache:mainfrom
Closed
allow uuid being created and managed by kubernetes#73colearendt wants to merge 3 commits intoapache:mainfrom
colearendt wants to merge 3 commits intoapache:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We utilize Helm's
lookupcommand to store a generateduuidin an "internal" secret in Kubernetes. This allows generating theuuid, making it persistent, and notifying the user (inNOTES.txt) that this auto-generation happened. We also tell the user how to disable the message by making that value persistent in values.Which issue this PR fixes
Special notes for your reviewer:
Happy to discuss this approach, messaging, etc. We have found similar patterns to strike a decent balance when secrets / inputs must exist outside of the application.
Open question: should we allow
dangerRegenerateAutomatedValues?(will walk through checklist once validated as a decent approach)
TODO: update docs accordingly / remove the
uuidgenerationChecklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.