Add CDVWebViewEngineConfigurationDelegate to expose the WKWebViewConfiguration#1157
Closed
msmtamburro wants to merge 10 commits intoapache:masterfrom
Closed
Add CDVWebViewEngineConfigurationDelegate to expose the WKWebViewConfiguration#1157msmtamburro wants to merge 10 commits intoapache:masterfrom
msmtamburro wants to merge 10 commits intoapache:masterfrom
Conversation
…View configuration (apache#900)
… conforming plugins use it
…ation with configuration
…iewWithFrame chore: clean up newCordovaViewWithFrame in order to extract initializ…
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
===========================================
+ Coverage 0 78.26% +78.26%
===========================================
Files 0 15 +15
Lines 0 1767 +1767
===========================================
+ Hits 0 1383 +1383
- Misses 0 384 +384
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
The Can you rebase so that this includes only the commit related to data storage? |
Contributor
Author
|
Yes! Just lost my access to push changes from work, so it may be a while.
|
|
@msmtamburro was this pull request final? Still marked as Draft? Is this pull request fully working ? |
…nto issue_900_websiteDataStore
Contributor
Author
|
Sorry it took so long to get back to you on this, but good news: nothing to do here. The commits in this PR safely made it to master in an earlier PR. I'll close this, and the associated issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
This can be merged after #1272
Motivation and Context
CDVWebViewEngine needs a way to set the websiteDataStore of its configuration.
Fixes:
#900
Description
Adds and exposes a protocol, CDVWebViewEngineConfigurationDelegate, which allows access to the configuration.
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))