fix: add WebViewAssetloader to default allow list#1275
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1275 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 21 21
Lines 1646 1646
=======================================
Hits 1206 1206
Misses 440 440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sakibguy
added a commit
to sakibguy/cordova-android
that referenced
this pull request
Jul 15, 2021
fix: add WebViewAssetloader to default allow list (apache#1275)
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Addresses issues in #1217
Closes #1217
Description
With the introduction of the WebViewAssetloader #1137 and the Allow List Plugin #1138 we need to add the origin / href the app is running to the allowlist.
Testing
Create a blank new app with one plugin
These steps will produce the hello world cordova app that should show "deviceready" with this pr. See issue.
Checklist
(platform)if this change only applies to one platform (e.g.(android))