Skip to content

feat: add backwards compatibility mode for WebViewAssetLoader#1222

Merged
NiklasMerz merged 3 commits intoapache:masterfrom
NiklasMerz:file
May 6, 2021
Merged

feat: add backwards compatibility mode for WebViewAssetLoader#1222
NiklasMerz merged 3 commits intoapache:masterfrom
NiklasMerz:file

Conversation

@NiklasMerz
Copy link
Copy Markdown
Member

@NiklasMerz NiklasMerz commented Apr 28, 2021

Platforms affected

Android

Motivation and Context

As we discussed on the list we might need a fallback for the new changes in #1137

With this PR you can fall back to using files instead of https://localhost with this preference:
<preference name="AndroidInsecureFileModeEnabled" value="true" />

Documentation: apache/cordova-docs#1172

Testing

Manual

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 28, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.97%. Comparing base (f9e8ce8) to head (615f946).
⚠️ Report is 264 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1222   +/-   ##
=======================================
  Coverage   71.97%   71.97%           
=======================================
  Files          21       21           
  Lines        1695     1695           
=======================================
  Hits         1220     1220           
  Misses        475      475           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NiklasMerz NiklasMerz added this to the 10.0.0 milestone Apr 28, 2021
@NiklasMerz NiklasMerz marked this pull request as ready for review May 3, 2021 08:01
@erisu erisu changed the title add backwards compatibility mode for WebViewAssetLoader feat: add backwards compatibility mode for WebViewAssetLoader May 3, 2021
@NiklasMerz NiklasMerz requested a review from PieterVanPoyer May 3, 2021 13:08
Copy link
Copy Markdown
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works fine, thanks!

@NiklasMerz NiklasMerz merged commit ff1ae21 into apache:master May 6, 2021
@NiklasMerz NiklasMerz deleted the file branch May 6, 2021 06:18
NiklasMerz added a commit that referenced this pull request Jul 14, 2021
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
chrisekelley added a commit to Tangerine-Community/docker-tangerine-base-image that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants