feat: add backwards compatibility mode for WebViewAssetLoader#1222
Merged
NiklasMerz merged 3 commits intoapache:masterfrom May 6, 2021
Merged
feat: add backwards compatibility mode for WebViewAssetLoader#1222NiklasMerz merged 3 commits intoapache:masterfrom
NiklasMerz merged 3 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1222 +/- ##
=======================================
Coverage 71.97% 71.97%
=======================================
Files 21 21
Lines 1695 1695
=======================================
Hits 1220 1220
Misses 475 475 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erisu
approved these changes
May 3, 2021
PieterVanPoyer
approved these changes
May 3, 2021
dpogue
approved these changes
May 3, 2021
jcesarmobile
approved these changes
May 5, 2021
Member
jcesarmobile
left a comment
There was a problem hiding this comment.
tested and works fine, thanks!
5 tasks
5 tasks
NiklasMerz
added a commit
that referenced
this pull request
Jul 14, 2021
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
chrisekelley
added a commit
to Tangerine-Community/docker-tangerine-base-image
that referenced
this pull request
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
As we discussed on the list we might need a fallback for the new changes in #1137
With this PR you can fall back to using files instead of https://localhost with this preference:
<preference name="AndroidInsecureFileModeEnabled" value="true" />Documentation: apache/cordova-docs#1172
Testing
Manual
Checklist
(platform)if this change only applies to one platform (e.g.(android))