Migrate to a newer JDK#8411
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8411 +/- ##
============================================
- Coverage 30.80% 4.39% -26.42%
============================================
Files 5341 361 -4980
Lines 374864 28622 -346242
Branches 54518 4992 -49526
============================================
- Hits 115485 1258 -114227
+ Misses 244114 27225 -216889
+ Partials 15265 139 -15126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DaanHoogland
left a comment
There was a problem hiding this comment.
good start let's see this through (cc @JoaoJandre )
| <version>1.5</version> | ||
| <groupId>org.codehaus.gmavenplus</groupId> | ||
| <artifactId>gmavenplus-plugin</artifactId> | ||
| <version>3.0.2</version> |
There was a problem hiding this comment.
can this come from the parent pom?
|
|
||
| <!-- Build properties --> | ||
| <cs.jdk.version>11</cs.jdk.version> | ||
| <cs.jdk.version>17</cs.jdk.version> |
There was a problem hiding this comment.
if we do 21 we have more time to think of our sins.
| <cs.jdk.version>17</cs.jdk.version> | |
| <cs.jdk.version>21</cs.jdk.version> |
There was a problem hiding this comment.
so this remains to be seen. depending on availabilities of libraries
fb7d5d8 to
a865652
Compare
|
@vishesh92 @weizhouapache can this be closed if #8411 is melded with #8497 ? |
This PR was for migrating the JDK and upgrade the packages required for that as well. This will require a lot of work. I am closing this PR for now. I will try to do this later in a way which includes small changes instead of a big PR. Most likely for 4.21. |
Description
This PR migrates jdk version from 11 to 21 🤞🏽 .
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?