Skip to content

[CASSANDRA-21288][trunk] Avoid Cell iterator for alive rows in MetricsRecording transformation of ReadCommand #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
netudima wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[CASSANDRA-21288][trunk] Avoid Cell iterator for alive rows in MetricsRecording transformation of ReadCommand #4709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/java/org/apache/cassandra/db/ReadCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,12 +644,15 @@ public Row applyToStatic(Row row)
public Row applyToRow(Row row)
{
boolean hasTombstones = false;
for (Cell<?> cell : row.cells())
if (row.hasDeletion(ReadCommand.this.nowInSec())) // perf optimization, to avoid iteration if all cells are alive
{
if (!cell.isLive(ReadCommand.this.nowInSec()))
for (Cell<?> cell : row.cells())
{
countTombstone(row.clustering());
hasTombstones = true; // allows to avoid counting an extra tombstone if the whole row expired
if (!cell.isLive(ReadCommand.this.nowInSec()))
{
countTombstone(row.clustering());
hasTombstones = true; // allows to avoid counting an extra tombstone if the whole row expired
}
}
}

Expand Down