Fix native memory leak in SSLFactory cache and resolve buffer offset corruption in EncryptionUtils#4706
Open
gagandhakrey wants to merge 1 commit intoapache:trunkfrom
Conversation
…uffer offset corruption in EncryptionUtils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem :
The SSLFactory class was leaking unmanaged tcnative/OpenSSL native memory because it removed SslContext objects from its cache without releasing their Netty reference counts, eventually leading to JVM crashes. Concurrently, EncryptionUtils possessed a critical memory corruption risk and ReadableByteChannel contract violation by improperly writing directly to dst.array() without calculating dst.arrayOffset() and failing to advance the buffer's position cursor after fulfilling the byte reads.
Fix :
In SSLFactory.java, guaranteed ReferenceCountUtil.release(ctx) is explicitly invoked every time a context is evicted from the cachedSslContexts map, ensuring the cache drops its baseline ownership cleanly without triggering double releases or disrupting active SSLEngine channels. In EncryptionUtils.java, DataInputReadChannel.read was updated to correctly index reads via dst.arrayOffset() + dst.position() and appropriately advance the buffer cursor using dst.position(dst.position() + readLength)