mbyrd/cassandra 21245/trunk Uncompressed size is being used for compressed tables in maintenance operations#4702
Open
Jollyplum wants to merge 2 commits intoapache:trunkfrom
Open
Conversation
…operations use compression ratio to scale the amount of remaining disk usage CompactionInfo::estimatedRemainingWriteBytes is uncompressed, causing compaction to be rejected due to size when it has space to complete patch by Matt Byrd; reviewed by for CASSANDRA-21245 Co-authored-by: Jon Meredith <jmeredithco@apple.com>
fix typo and add CHANGES.txt entry
netudima
reviewed
Apr 5, 2026
| public CompactionInfo getCompactionInfo() | ||
| { | ||
| return new CompactionInfo(metadata, OperationType.COMPACTION, 0, 1000, nextTimeUUID(), sstables); | ||
| return new CompactionInfo(metadata, OperationType.COMPACTION, 0, 1000, 0, nextTimeUUID(), sstables); |
Contributor
There was a problem hiding this comment.
nit: do we set compressed value as 0 intentionally here?
netudima
reviewed
Apr 5, 2026
| } | ||
| } | ||
|
|
||
| private static final class OnDiskLengthOverrideSSTableReader extends ForwardingSSTableReader |
Contributor
There was a problem hiding this comment.
just wondering what is the purpose of the Reader substitution?.. (if in any way we use a custom Holder to return getCompactionInfo)
netudima
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use compression ratio to scale the amount of remaining disk usage
CompactionInfo::estimatedRemainingWriteBytes is uncompressed, causing compaction to be rejected due to size when it has space to complete
Will attach CI run to the JIRA.
CASSANDRA-21245