CASSSIDECAR-417 : CdcManager.getInstanceId(instanceIp) returns -1 as it resolves ipAddress to null#332
Open
jyothsnakonisa wants to merge 4 commits intoapache:trunkfrom
Open
CASSSIDECAR-417 : CdcManager.getInstanceId(instanceIp) returns -1 as it resolves ipAddress to null#332jyothsnakonisa wants to merge 4 commits intoapache:trunkfrom
jyothsnakonisa wants to merge 4 commits intoapache:trunkfrom
Conversation
skoppu22
reviewed
Mar 31, 2026
server/src/main/java/org/apache/cassandra/sidecar/cdc/CdcManager.java
Outdated
Show resolved
Hide resolved
skoppu22
approved these changes
Mar 31, 2026
skoppu22
reviewed
Mar 31, 2026
server/src/main/java/org/apache/cassandra/sidecar/cdc/CdcManager.java
Outdated
Show resolved
Hide resolved
skoppu22
reviewed
Mar 31, 2026
skoppu22
approved these changes
Mar 31, 2026
jmckenzie-dev
requested changes
Apr 1, 2026
server/src/test/java/org/apache/cassandra/sidecar/cdc/CdcManagerTest.java
Show resolved
Hide resolved
jmckenzie-dev
approved these changes
Apr 1, 2026
…it resolves ipAddress to null
jyothsnakonisa
force-pushed
the
get-instance-id
branch
from
8330088 to
9b8f166
Compare
| LOGGER.warn("Could not resolve hostname: {}", e.getMessage()); | ||
| return address1.equals(address2); // Fallback to string comparison | ||
| LOGGER.warn("Requested IP {} does not match with any instances", instanceIp); | ||
| return -1; |
There was a problem hiding this comment.
wdyt about, instead of using -1 here as a magic number, we define a static constant UNKNOWN_INSTANCE or something we return when we fail to match and check against?
Contributor
Author
There was a problem hiding this comment.
Yup agree, that looks better!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.