fix: fix race in Uuids.ClockSeqAndNodeContainer double-checked init#2050
Open
jasonk000 wants to merge 1 commit intoapache:4.xfrom
Open
fix: fix race in Uuids.ClockSeqAndNodeContainer double-checked init#2050jasonk000 wants to merge 1 commit intoapache:4.xfrom
jasonk000 wants to merge 1 commit intoapache:4.xfrom
Conversation
lukasz-antoniak
approved these changes
Feb 24, 2026
Member
lukasz-antoniak
left a comment
There was a problem hiding this comment.
Thanks for the patch!
Member
|
Can you just change commit message to |
lukasz-antoniak
requested changes
Feb 24, 2026
Member
lukasz-antoniak
left a comment
There was a problem hiding this comment.
Good catch, just please change commit message. I do not think we need a JIRA for such a small change.
c475bf7 to
ca7ed6b
Compare
Contributor
Author
|
@lukasz-antoniak done! |
Member
|
Just the one-line |
ca7ed6b to
6798e1e
Compare
Contributor
Author
|
@lukasz-antoniak done done! =) |
lukasz-antoniak
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reordered writes in ClockSeqAndNodeContainer.get() to assign
valbefore setting the volatileinitializedflag.The updated sequence ensures
valis fully constructed and visible before publication via the volatile write.