[CALCITE-7550] SqlUpdate and SqlDelete unparse EXISTS subqueries without parentheses#4969
Open
zzwqqq wants to merge 1 commit into
Open
[CALCITE-7550] SqlUpdate and SqlDelete unparse EXISTS subqueries without parentheses#4969zzwqqq wants to merge 1 commit into
zzwqqq wants to merge 1 commit into
Conversation
|
mihaibudiu
approved these changes
May 26, 2026
Contributor
|
Is the same problem valid for MERGE ? I think it is possible to specify EXISTS inside ON clause |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Jira Link
CALCITE-7550
Changes Proposed
Fixes unparsing of
EXISTSsubqueries inUPDATEandDELETEstatements.SqlUpdateandSqlDeletewere unparsing theWHEREcondition directly, which could produce invalid SQL such asWHERE EXISTS SELECT ....This change moves the existing
WHEREunparsing logic fromSqlSelectOperatorintoSqlUtil.unparseWhereClauseand reuses it forSELECT,UPDATE, andDELETE, so DML statements use the sameWHERE_LISTframe behavior as queries.Adds regression tests for
UPDATEandDELETEwithEXISTSpredicates.