[CALCITE-7304] Floor/Ceil can not simplify with WEEK TimeUnit#4966
[CALCITE-7304] Floor/Ceil can not simplify with WEEK TimeUnit#4966xuzifu666 wants to merge 1 commit into
Conversation
| final RexCall floorSimplifiedExpr = | ||
| (RexCall) nonParanoidSimplify.simplifyPreservingType(outerFloorCall, | ||
| RexUnknownAs.UNKNOWN, true); | ||
| assertThat(floorSimplifiedExpr, hasToString(outerFloorCall.toString())); |
There was a problem hiding this comment.
isn't the simplified expression the same as the original one?
that assertion would be simpler and clearer
There was a problem hiding this comment.
You're right. The negative test cases (lines 607-650) were indeed overly verbose. Each test was duplicating, I had changed them. Thanks for the suggestion!
There was a problem hiding this comment.
I'd like to know if you are happy with the changes made in the current test. @mihaibudiu
There was a problem hiding this comment.
Sure. I have approved. If this is slated for 1.43 you can merge, otherwise you should probably wait for the release
There was a problem hiding this comment.
Thanks for the reminder! Since version 1.42 is about to be released, I will wait to merge it after 1.42 release.
mihaibudiu
left a comment
There was a problem hiding this comment.
This is fine, but perhaps the tests can be simplified.
|



jira: https://issues.apache.org/jira/browse/CALCITE-7304