Skip to content

Version new rules#743

Merged
asfgit merged 22 commits intoapache:masterfrom
ahgittin:version-new-rules
Jun 30, 2017
Merged

Version new rules#743
asfgit merged 22 commits intoapache:masterfrom
ahgittin:version-new-rules

Conversation

@ahgittin
Copy link
Contributor

Implements the behaviour discussed on ML re version syntax.

Places where OSGi syntax is required (ie registering/searching OSGi bundles) convert to the OSGi syntax. Everywhere else uses the version string exactly as supplied by the caller. Places where mappings to OSGi are not unique result in warnings.

The fixes the issue described in #672, and catalog.bom files can (should) now use familiar maven/semver versions (#.#.#-qual) which most people seem to use everywhere else. This is converted to OSGi syntax (#.#.#.qual) when creating the bundle, or comparing with installed bundles, but that's all hidden from users (unless they go deep into OSGi).

You can supply OSGi syntax (or even crazy things like v1) in the catalog.bom, and the syntax supplied is exactly what will be used in the Brooklyn catalog. There will be warnings if it does not follow the recommended syntax but they can be ignored.

This builds on (and closes) #737 and #740, depending whether people want to review those independently or in the context of this.

Merge apache/brooklyn-docs#198 once this is merged.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants