Open
Conversation
cetra3
force-pushed
the
sbbf_public_methods
branch
from
91c414d to
dc8aba8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
We want to use the SBBF Bloom Filter, but need to construct/serialize it manually. Currently there is no way to create a new
Sbbfoutside of this crate. Alongside this: we want to store theSbbfin aFixedSizedBinarycolumn for some fancy indexing.What changes are included in this PR?
Some methods become public
Are these changes tested?
N/A
Are there any user-facing changes?
Yes, we add a few more public methods to the
Sbbfstruct