Add mutable operations to BooleanBuffer (Bit*Assign)#9567
Open
Dandandan wants to merge 5 commits intoapache:mainfrom
Open
Add mutable operations to BooleanBuffer (Bit*Assign)#9567Dandandan wants to merge 5 commits intoapache:mainfrom
Dandandan wants to merge 5 commits intoapache:mainfrom
Conversation
Dandandan
changed the title
alamb
reviewed
Mar 17, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
The code looks good to me -- thanks @Dandandan
I do think we need some tests and some additional documentation would help
Here is a proposal:
arrow-buffer/src/buffer/boolean.rs
Outdated
| self.buffer.claim(pool); | ||
| } | ||
|
|
||
| /// Apply a bitwise binary operation in-place, avoiding allocation if the |
Contributor
There was a problem hiding this comment.
I think we need some tests for this code
Suggestions for "Add mutable operations to BooleanBuffer (Bit*Assign)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I want to avoid allocating a new buffer when doing
&.We can use
&=this way.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?