add shred_variant support for LargeUtf8 and LargeBinary#9554
Merged
scovich merged 1 commit intoapache:mainfrom Mar 16, 2026
Merged
add shred_variant support for LargeUtf8 and LargeBinary#9554scovich merged 1 commit intoapache:mainfrom
shred_variant support for LargeUtf8 and LargeBinary#9554scovich merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@klion26 @codephage2020 @scovich Please take a look when you are available. Thanks! |
Contributor
Author
|
@scovich It is, thanks! |
klion26
approved these changes
Mar 16, 2026
Member
klion26
left a comment
klion26
left a comment
There was a problem hiding this comment.
LGTM, thanks for the improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
shred_variantsupport forLargeUtf8andLargeBinarytypes #9525 .Rationale for this change
check issue.
What changes are included in this PR?
Add
shred_variantsupport forLargeUtf8andLargeBinaryAre these changes tested?
Yes, unit tests.
Are there any user-facing changes?
No