introduce StatisticsConverter::from_column_index#9540
Open
friendlymatthew wants to merge 1 commit intoapache:mainfrom
Open
introduce StatisticsConverter::from_column_index#9540friendlymatthew wants to merge 1 commit intoapache:mainfrom
friendlymatthew wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
Related to apache/datafusion#20871 |
alamb
reviewed
Mar 17, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @friendlymatthew -- sorry for the delayed review
| }) | ||
| } | ||
|
|
||
| /// Create a new `StatisticsConverter` from a Parquet leaf column index directly. |
Contributor
There was a problem hiding this comment.
Thanks @friendlymatthew -- this makes sense to me.
However, I think we need at least some basic tests showing this working (aka create a Parquet file with a struct column and then read the statistics out of it using this API)
Contributor
Author
There was a problem hiding this comment.
Sounds good. You may also like this! apache/datafusion#21003 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR adds a constructor StatisticsConverter::from_column_index that bypasses schema resolution and accepts a pre-resolved leaf column index directly
Datafusion's pruning predicate system needs stats for struct fields to support predicate pushdown on expressions like
WHERE my_struct.field > 67. Datafusion already resolves struct fields to Parquet leaf indices elsewhere, but has no way to pass that index to StatisticsConverter