Skip to content

[Variant] clean up variant_get tests #9518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 11 commits into from
Mar 18, 2026
Merged

[Variant] clean up variant_get tests #9518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f64d4df
Cleanup
sdf-jkl Mar 5, 2026
718efbf
bug fix
sdf-jkl Mar 5, 2026
0aea350
Merge branch 'main' of https://github.com/apache/arrow-rs into varian…
sdf-jkl Mar 10, 2026
cc1869f
code movement
sdf-jkl Mar 10, 2026
ff485cd
More idiomatic macro
sdf-jkl Mar 10, 2026
a56a368
use `ShreddedVariantFieldArray::from_parts`
sdf-jkl Mar 10, 2026
bdb036f
Move comment
sdf-jkl Mar 10, 2026
7055ebb
Merge branch 'main' of https://github.com/apache/arrow-rs into varian…
sdf-jkl Mar 16, 2026
5af483f
make utf8 fixture have both typed and untyped values
sdf-jkl Mar 16, 2026
bc3c4c1
Merge branch 'main' of https://github.com/apache/arrow-rs into varian…
sdf-jkl Mar 16, 2026
2596ecf
update comments
sdf-jkl Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions parquet-variant-compute/src/shred_variant.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,7 +1147,6 @@ mod tests {
}

#[test]
// TODO(#9518): Drop this once variant_get tests build shredded fixtures via shred_variant.
Copy link
Copy Markdown
Contributor Author

@sdf-jkl sdf-jkl Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized the tests we use in variant_get.rs create a perfectly shredded array, so it's not doing full multi type validation.

We should keep the shred_variant.rs tests as is.

fn test_largeutf8_shredding() {
let input = VariantArray::from_iter(vec![
Some(Variant::from("hello")),
Expand Down Expand Up @@ -1204,7 +1203,6 @@ mod tests {
}

#[test]
// TODO(#9518): Drop this once variant_get tests build shredded fixtures via shred_variant.
fn test_largebinary_shredding() {
let input = VariantArray::from_iter(vec![
Some(Variant::from(&b"\x00\x01\x02"[..])),
Expand Down
2 changes: 1 addition & 1 deletion parquet-variant-compute/src/type_conversion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ impl_primitive_from_variant!(datatypes::Time32MillisecondType, as_time_utc, |v|
}
});
impl_primitive_from_variant!(datatypes::Time64MicrosecondType, as_time_utc, |v| {
Some((v.num_seconds_from_midnight() * 1_000_000 + v.nanosecond() / 1_000) as i64)
Some(v.num_seconds_from_midnight() as i64 * 1_000_000 + v.nanosecond() as i64 / 1_000)
Copy link
Copy Markdown
Contributor

@alamb alamb Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this necessary?

Copy link
Copy Markdown
Contributor Author

@sdf-jkl sdf-jkl Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9518 (comment)

});
impl_primitive_from_variant!(datatypes::Time64NanosecondType, as_time_utc, |v| {
// convert micro to nano seconds
Expand Down
Loading
Loading