GH-1004: [JDBC] Fix NPE in ArrowFlightJdbcDriver#connect(final String url, final Properties info) #1005
Open
ennuite wants to merge 3 commits intoapache:mainfrom
Open
GH-1004: [JDBC] Fix NPE in ArrowFlightJdbcDriver#connect(final String url, final Properties info) #1005ennuite wants to merge 3 commits intoapache:mainfrom
ennuite wants to merge 3 commits intoapache:mainfrom
Conversation
ennuite
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
jbonofre
approved these changes
Feb 8, 2026
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
That should be pretty rare, but worth to avoid this.
Member
|
NB: the tests won't pass (see #1002). I will rebase as soon as CI is green again. |
Member
|
@ennuite can you please rebase this PR ? The CI should be ok now. |
Contributor
Author
|
@jbonofre done. Is this ok to merge? It seems like CI only ran the format and not the tests... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
ArrowFlightJdbcDriver.connect(final String url, final Properties info)now properly ignores a null value forinfo, obtaining the properties solely from the URL.Closes #1004.