feat(apisix): add configurable livenessProbe support#952
Open
feillu-a wants to merge 1 commit intoapache:masterfrom
Open
feat(apisix): add configurable livenessProbe support#952feillu-a wants to merge 1 commit intoapache:masterfrom
feillu-a wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds an optional
livenessProbeconfiguration to the APISIX chart.Currently, only a
readinessProbe(TCP on :9080) is configured. Without alivenessProbe, a frozen APISIX process (no crash, but unresponsive) willcause the pod to stay in
Not Readystate indefinitely without ever beingrestarted by Kubernetes.
Changes
values.yaml: addlivenessProbeblock withenabled: falseby defaulttemplates/deployment.yaml: inject the probe when enabledHow to test
The pod should now be restarted automatically if APISIX stops responding on :9080.
Closes #951