charts/ingress-controller: add global.imagePullSecrets support#948
Closed
martin-schulze-e2m wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
martin-schulze-e2m
changed the title
martin-schulze-e2m
changed the title
Author
|
I just found #916, it is beyond my why me previous search did not turn that up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pulling the ingress-controller from a registry with authentication is currently not possible. This makes working around the Dockerhub ratelimiting hard.
Details
Since the ingress-controller is used as a subchart by apisix, which already defines
global.imagePullSecrets, I decided to reuse them.