Skip to content

feat(ingress-controller): add imagePullSecrets support with global fallback #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Baoyuantop merged 5 commits into from
Mar 26, 2026
Merged

feat(ingress-controller): add imagePullSecrets support with global fallback #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9950cb6
feature(apisix-ingress-controller): add the posibility to put a Image…
ArnaudCHT Dec 15, 2025
b4e66a9
feature(apisix-ingress-controller): add the posibility to put a Image…
ArnaudCHT Dec 15, 2025
2577083
Merge branch 'master' into feature/imagepullsecret
ArnaudCHT Mar 4, 2026
d0d45b8
Update charts/apisix-ingress-controller/README.md
ArnaudCHT Mar 10, 2026
417b316
fix: align imagePullSecrets format with main apisix chart
Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/apisix-ingress-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ The same for container level, you need to set:
| deployment.image.pullPolicy | string | `"IfNotPresent"` | |
| deployment.image.repository | string | `"apache/apisix-ingress-controller"` | |
| deployment.image.tag | string | `"2.0.1"` | |
| deployment.imagePullSecrets | list | `[]` | |
| deployment.nodeSelector | object | `{}` | |
| deployment.podAnnotations | object | `{}` | |
| deployment.podSecurityContext | object | `{"fsGroup":2000}` | Set security context for the pod fsGroup: 2000 ensures containers can share Unix socket files via a common group. |
Expand Down
7 changes: 7 additions & 0 deletions charts/apisix-ingress-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ spec:
labels:
{{- include "apisix-ingress-controller-manager.selectorLabels" . | nindent 8 }}
spec:
{{- $imagePullSecrets := .Values.deployment.imagePullSecrets | default ((.Values.global).imagePullSecrets | default list) }}
{{- with $imagePullSecrets }}
imagePullSecrets:
{{- range $imagePullSecrets }}
- name: {{ . }}
{{- end }}
{{- end }}
containers:
- env:
- name: POD_NAMESPACE
Expand Down
1 change: 1 addition & 0 deletions charts/apisix-ingress-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ deployment:
nodeSelector: {}
tolerations: []
affinity: {}
imagePullSecrets: []
Comment thread
Baoyuantop marked this conversation as resolved.

# -- Set security context for the pod
# fsGroup: 2000 ensures containers can share Unix socket files via a common group.
Expand Down
Loading