Skip to content

fix(plugin): add confirmation dialog before deleting plugin card#3345

Open
Jaswanth-arjun wants to merge 2 commits intoapache:masterfrom
Jaswanth-arjun:master
Open

fix(plugin): add confirmation dialog before deleting plugin card#3345
Jaswanth-arjun wants to merge 2 commits intoapache:masterfrom
Jaswanth-arjun:master

Conversation

@Jaswanth-arjun
Copy link
Copy Markdown

Description

Currently, deleting a plugin from forms (Routes, Services, Plugin Configs) happens immediately without confirmation, which may lead to accidental data loss.

Changes

  • Added confirmation dialog using modals.openConfirmModal
  • Prevents accidental deletion of plugin configurations
  • Aligns behavior with existing DeleteResourceBtn UX

Impact

  • Improves user experience
  • Ensures consistency across dashboard delete actions
  • Reduces risk of unintended data loss

Related Issue

Testing

  • Added plugin, confirmed delete shows confirmation modal
  • Cancel button closes modal without deleting
  • Confirm button deletes plugin as expected
image

@Baoyuantop
Copy link
Copy Markdown
Contributor

I don’t think this feature is necessary. Since we’re currently on the data creation page rather than the edit page, removing the plugin simply deletes it from the data being created—it has no impact on active configurations. Therefore, there’s no need for this additional confirmation.

Hi @Jaswanth-arjun, before submitting a contribution, please create an issue describing your problem or request. Once the community has reviewed and approved it, submit a pull request to complete the code.

@Jaswanth-arjun
Copy link
Copy Markdown
Author

Hi @Baoyuantop actually i am fixing bugs which are i seen in issues tab #3342
and my PR was #3345 ,Thank you for your suggestion.

@Baoyuantop Baoyuantop linked an issue Mar 24, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ux): no confirmation dialog when deleting a plugin from form

2 participants