feat: add global copyable IDs and stabilize e2e flows#3340
feat: add global copyable IDs and stabilize e2e flows#3340Baluduvamsi2006 wants to merge 3 commits intoapache:masterfrom
Conversation
|
@Baoyuantop , could you please review this PR when you have time? I also included e2e stability fixes in this PR. Without these fixes, path-resolution issues and flaky UI interactions in the e2e helpers made it difficult to identify true pass/fail results. I fixed those issues in the same PR so the test output is now reliable and actionable. |
Baoyuantop
left a comment
There was a problem hiding this comment.
The CopyableText abstraction for reuse is a good direction. A few items to address:
-
Issue reference:
#0001in the PR description is a placeholder. Please link the actual related issue(s). -
e2e interaction: The TLS Verify switch uses
evaluate(click)which bypasses Playwright's normal visibility/actionability checks. Please usegetByTestId+ standard click instead. Ifevaluateis necessary, please document why. -
PR scope: Mixing feature work (copyable IDs) with e2e stability fixes in one PR creates coupled merge decisions and coarse rollback granularity. Please consider splitting into two PRs.
-
Component testing: Please add at least one component-level test for
CopyableText(successful copy / empty value / failure branch).
Why submit this pull request?
What changes will this PR take into?
This PR introduces global one-click copy-to-clipboard support for key resource identifiers and includes related e2e reliability fixes.
Checklist:
Notes: