fix(e2e): improve Monaco editor handling and fallback#3331
Draft
Baluduvamsi2006 wants to merge 2 commits intoapache:masterfrom
Draft
fix(e2e): improve Monaco editor handling and fallback#3331Baluduvamsi2006 wants to merge 2 commits intoapache:masterfrom
Baluduvamsi2006 wants to merge 2 commits intoapache:masterfrom
Conversation
…t pages This commit consolidates all changes from the refactor/resource-list-page branch: - Introduces ResourceListPage component to reduce code duplication across list pages - Standardizes pagination, sorting, and filtering behavior across all resource lists - Fixes React infinite re-render loops by using stable query results - Improves E2E test reliability with dynamic polling instead of hardcoded waits - Removes unused imports and fixes TypeScript/ESLint warnings - Adds proper integer validation for pagination parameters - Improves error handling in upstream deletion with 400 status code tolerance
- Increase test timeout to 120s for comprehensive upstream->service->route test - Add explicit page.waitForLoadState() calls after navigation - Add scrollIntoViewIfNeeded() before clicking row buttons - Add explicit timeouts to expect() calls for better debugging - Wrap row element selection to avoid multiple chained locator calls
Contributor
|
Thanks for the contribution! This PR is doing too many things at once (57 files, 5+ independent concerns), which makes it hard to review safely. I'd suggest splitting it:
A few things to address regardless:
Please split into focused PRs so we can review and merge incrementally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds proper Monaco editor detection and graceful fallback for test scenarios