Fixes LocatorIT when locating tablets for offline table#6194
Merged
dlmarion merged 2 commits intoapache:2.1from Mar 9, 2026
Merged
Fixes LocatorIT when locating tablets for offline table#6194dlmarion merged 2 commits intoapache:2.1from
dlmarion merged 2 commits intoapache:2.1from
Conversation
The TabletLocator no longer throws an exception when trying to locate tablets for an offline table due to the changes in PR apache#6156 that allows Scan Servers to scan an offline table.
keith-turner
reviewed
Mar 6, 2026
|
|
||
| tableOps.offline(tableName, true); | ||
|
|
||
| assertThrows(TableOfflineException.class, () -> tableOps.locate(tableName, ranges)); |
Contributor
There was a problem hiding this comment.
Could this be modified to check the return value for this case?
Contributor
Author
There was a problem hiding this comment.
I reverted this change in the most recent commit and instead put a check in TableOperationsImpl to ensure the behavior didn't change between releases. I re-ran ScanServerOfflineTableIT with these changes and it works, the Scanner/BatchScanner code don't use TableOperations.
keith-turner
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TabletLocator no longer throws an exception when trying to locate tablets for an offline table due to the changes in PR #6156 that allows Scan Servers to scan an offline table.