Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package webindex.data.fluo;
Comment thread
keith-turner marked this conversation as resolved.

import java.net.MalformedURLException;

import org.junit.Test;

import webindex.core.models.Page;
import webindex.core.models.URL;


public class PageLoaderTest {

@Test
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be @Test(expected = NullPointerException.class)?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpm1985 do you know if this is still an issue?

public void testUpdatePageWithNullPage() {
PageLoader.updatePage((Page) null);
}

@Test(expected = IllegalArgumentException.class)
public void testUpdatePageWithEmptyPage() {
PageLoader.updatePage(Page.EMPTY);
}

@Test(expected = NullPointerException.class)
public void testDeletePageThrowsNPEifNullURL() throws MalformedURLException{
PageLoader.deletePage((URL)null);
}

@Test
public void testDeletePageWithBlankURL() throws MalformedURLException{
URL url = new URL("","","",0,false,false);
PageLoader.deletePage(url);
}

@Test
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be @Test(expected = NullPointerException.class)? Also if that change is made seem like all of the catch blocks could be dropped.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpm1985 do you know if this is still an issue?

public void testLoadWithNullTxCtx() throws Exception{
URL url = new URL("www.apache.org", "www.apache.org", "http://www.apache.org", 80, false, false);
PageLoader loader = PageLoader.deletePage(url);
loader.load(null, null);
}
}