-
Notifications
You must be signed in to change notification settings - Fork 7
Initial PageLoader Test ClassInitial test for the PageLoader class that covers null and empty checks #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Initial PageLoader Test ClassInitial test for the PageLoader class that covers null and empty checks #8
Changes from all commits
8ee6023
80e1033
216dccd
7d94a3c
abd15cc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package webindex.data.fluo; | ||
|
|
||
| import java.net.MalformedURLException; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import webindex.core.models.Page; | ||
| import webindex.core.models.URL; | ||
|
|
||
|
|
||
| public class PageLoaderTest { | ||
|
|
||
| @Test | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kpm1985 do you know if this is still an issue? |
||
| public void testUpdatePageWithNullPage() { | ||
| PageLoader.updatePage((Page) null); | ||
| } | ||
|
|
||
| @Test(expected = IllegalArgumentException.class) | ||
| public void testUpdatePageWithEmptyPage() { | ||
| PageLoader.updatePage(Page.EMPTY); | ||
| } | ||
|
|
||
| @Test(expected = NullPointerException.class) | ||
| public void testDeletePageThrowsNPEifNullURL() throws MalformedURLException{ | ||
| PageLoader.deletePage((URL)null); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDeletePageWithBlankURL() throws MalformedURLException{ | ||
| URL url = new URL("","","",0,false,false); | ||
| PageLoader.deletePage(url); | ||
| } | ||
|
|
||
| @Test | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kpm1985 do you know if this is still an issue? |
||
| public void testLoadWithNullTxCtx() throws Exception{ | ||
| URL url = new URL("www.apache.org", "www.apache.org", "http://www.apache.org", 80, false, false); | ||
| PageLoader loader = PageLoader.deletePage(url); | ||
| loader.load(null, null); | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.