Add missing paths to wave_buoy_realtime_nonqc.json#263
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the wave_buoy_realtime_nonqc dataset configuration to include additional IMOS S3 source prefixes so the ingestion run covers more real-time wave buoy NetCDF files.
Changes:
- Added four missing
run_settings.pathsentries for additional real-time wave buoy S3 prefixes. - Extended coverage to include UWA and additional IMOS ANMN subtrees, plus a South Australia department prefix.
| "s3_uri": "s3://imos-data/Department_for_Environment_and_Water-South_Australia/WAVE-BUOYS/REALTIME/", | ||
| "filter": [ | ||
| ".*\\.nc" | ||
| ], | ||
| "year_range": [] |
There was a problem hiding this comment.
Adding the Department_for_Environment_and_Water-South_Australia S3 path introduces a new data provider name that isn’t currently reflected in the dataset’s aws_opendata_registry metadata (both the long Description and the Citation currently reference “SARDI” but not this department). Please update the registry metadata to match the actual provider naming used in run_settings.paths (or rename the path prefix if the intent is to attribute the data to SARDI).
There was a problem hiding this comment.
@mphemming happy to merge, but can you create a backlog item not to forget this bit?
There was a problem hiding this comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage ? 65.90%
=======================================
Files ? 29
Lines ? 5327
Branches ? 0
=======================================
Hits ? 3511
Misses ? 1816
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.