Security: Unsafe HTML construction in helper allows injection into output#1084
Open
tuanaiseo wants to merge 1 commit intoanvilco:mainfrom
Open
Conversation
…ctio `spanWrap` interpolates `className` and `value` directly into an HTML string. If either comes from untrusted spec data, this enables HTML attribute/content injection (e.g., breaking out of attributes or injecting tags) when rendered unescaped or via triple-stash usage. Affected files: spanWrap.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
spanWrapinterpolatesclassNameandvaluedirectly into an HTML string. If either comes from untrusted spec data, this enables HTML attribute/content injection (e.g., breaking out of attributes or injecting tags) when rendered unescaped or via triple-stash usage.Severity:
highFile:
src/themes/default/helpers/spanWrap.jsSolution
Escape both attribute and text contexts before interpolation (or build DOM-safe output via templating primitives). Restrict
classNameto a safe pattern like/^[a-zA-Z0-9_- ]+$/.Changes
src/themes/default/helpers/spanWrap.js(modified)Testing