Add Cooler Master SK630 Keyboard support#2260
Open
Herringway wants to merge 2 commits intoantonpup:devfrom
Open
Add Cooler Master SK630 Keyboard support#2260Herringway wants to merge 2 commits intoantonpup:devfrom
Herringway wants to merge 2 commits intoantonpup:devfrom
Conversation
Author
|
Is anyone around to review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List any issues that this PR fixes: fixes #1914
This pull request proposes the following changes:
Known issues/To do:
Though the SK630 is pretty much just a SK650 without the numpad, some of the edge lights were moved as well. I've tested this with my own keyboard.