ds4_server: check if client disconnected to abort inference early#242
Open
confiden wants to merge 1 commit into
Open
ds4_server: check if client disconnected to abort inference early#242confiden wants to merge 1 commit into
confiden wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Detect client disconnection during non-streaming inference and abort generation early to allow the next queued worker to begin
Description
Problem
The ds4-server uses a single-worker-thread architecture. When a client disconnects mid-request (drops their HTTP connection), the worker continues generating tokens until the response is fully complete before noticing the failure. For non-streaming requests, there is no interaction with the client socket during the decode loop, so a dropped connection is never detected until the final send(). This wastes GPU time an more importantly, blocks the single worker thread from processing any subsequent queued requests.
Solution
Add a lightweight, per-token health check on the client socket inside the decode loop for non-streaming requests. Before sampling each tokepoll() the fd with a zero timeout. If the peer has closed the connection, abort generation immediately with finish = "error".
Cross-platform notes
Changes
Testing