Fix CLI -d flag to set SRT_DEBUG instead of DEBUG#208
Open
hattori7243 wants to merge 1 commit intoanthropic-experimental:mainfrom
Open
Fix CLI -d flag to set SRT_DEBUG instead of DEBUG#208hattori7243 wants to merge 1 commit intoanthropic-experimental:mainfrom
hattori7243 wants to merge 1 commit intoanthropic-experimental:mainfrom
Conversation
The -d/--debug flag was setting `process.env.DEBUG` but `logForDebugging()` checks `process.env.SRT_DEBUG`, so the flag never actually enabled debug logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-d/--debugflag to setSRT_DEBUGinstead ofDEBUGProblem
The CLI's
-d/--debugflag setsprocess.env.DEBUG, butlogForDebugging()checksprocess.env.SRT_DEBUG. This means the debug flag never actually enabled debug logging.This was intentional —
SRT_DEBUGis used instead ofDEBUGto avoid conflicts with other tools ( but the CLI flag was never updated to match.Test plan
srt -d echo hellonow shows[SandboxDebug]prefixed output on stderrbun test test/cli.test.ts)