Fix regex special character escaping in seatbelt rules for paths with brackets#134
Open
Fix regex special character escaping in seatbelt rules for paths with brackets#134
Conversation
…bypass via paths like He[ll]o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paths containing regex-special characters like
[and](e.g.,/Users/jbo/Projects/He[ll]o) were not properly escaped when generating macOS Seatbelt regex rules. This caused[ll]to be interpreted as a regex character class (matching a singlel) instead of the literal string[ll], so deny rules would not match the actual path.Fix:
[and]inglobToRegex()alongside other regex special characters[and]fromcontainsGlobChars()so literal paths with brackets use(subpath ...)rules instead of being misrouted through regexnormalizePathForSandbox(),expandGlobPattern(), andgenerateMoveBlockingRules()to not split on[and][abc]glob character class support (not used anywhere in this codebase)