Clean temporary files before mounted empty directories during cleanup#133
Open
k3a wants to merge 1 commit intoanthropic-experimental:mainfrom
Open
Clean temporary files before mounted empty directories during cleanup#133k3a wants to merge 1 commit intoanthropic-experimental:mainfrom
k3a wants to merge 1 commit intoanthropic-experimental:mainfrom
Conversation
Some paths require an empty directory to be mounted. This is done by Fix 2 and creates an empty directory in the host. Then a /dev/null file may be mounted into that directory. During cleanup, a directory is sometimes unsucessfully attempted to be cleaned before cleaning that empty file inside. Sorting mountpoints from the longest to the shortest ensures temporary files are cleaned before an attempt to clean a directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some paths require an empty directory to be mounted. This is done by Fix 2 and creates an empty directory in the host. Then a /dev/null file may be mounted into that directory.
During cleanup, a directory is sometimes unsucessfully attempted to be cleaned before cleaning that empty file inside.
Sorting mountpoints from the longest to the shortest ensures temporary files are cleaned before an attempt to clean a directory.