Fix glob-suffixed allowWrite paths silently dropped in wrapWithSandbox#128
Open
wjordan wants to merge 1 commit intoanthropic-experimental:mainfrom
Open
Fix glob-suffixed allowWrite paths silently dropped in wrapWithSandbox#128wjordan wants to merge 1 commit intoanthropic-experimental:mainfrom
wjordan wants to merge 1 commit intoanthropic-experimental:mainfrom
Conversation
wrapWithSandbox() passed raw glob paths (e.g. /path/**) straight to generateFilesystemArgs(), where existsSync() on the literal glob path returned false, silently dropping the write mount. getFsWriteConfig() already stripped these correctly via removeTrailingGlobSuffix(), creating a discrepancy between the reported config and actual sandbox mounts. Apply the same removeTrailingGlobSuffix() + Linux glob filtering in wrapWithSandbox() to match getFsWriteConfig().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrapWithSandbox()passed raw glob paths (e.g./path/**) straight togenerateFilesystemArgs(), whereexistsSync()on the literal glob path returned false, silently dropping the write mount.getFsWriteConfig()already stripped these correctly viaremoveTrailingGlobSuffix(), creating a discrepancy between the reported config and actual sandbox mounts.Apply the same
removeTrailingGlobSuffix()+ Linux glob filtering inwrapWithSandbox()to matchgetFsWriteConfig().