fix(tui): handle non-git project paths when opening editor#29180
Open
OpeOginni wants to merge 1 commit into
Open
fix(tui): handle non-git project paths when opening editor#29180OpeOginni wants to merge 1 commit into
OpeOginni wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16071
Type of change
What does this PR do?
When opening the external editor from the TUI prompt or session export, the cwd was resolved as:
project.instance.path().worktree || project.instance.directory() || process.cwd()For non-git projects, worktree is intentionally set to "/" (see
src/project/project.ts). Because "/" is truthy, it was selected as the working directory, causing the editor to open at the filesystem root instead of the actual project directory.Fix
Treat "/" as an invalid worktree at the three Editor.open() call sites so the fallback chain correctly resolves to
project.instance.directory().How did you verify your code works?
Screenshots / recordings
Checklist