fix(tui): interaction improvements to diff viewer#28851
Merged
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A
Type of change
What does this PR do?
This improves interactions in the TUI diff viewer.
The main fix is that next and previous file navigation now uses the ordered patch file list instead of relying on viewport-derived state. This makes navigation more reliable when the file tree is focused, when single-patch mode is enabled, and when switching between single-patch and all-patches views.
It also keeps the selected patch and file tree selection synchronized, scrolls the selected patch after render when needed, and keeps selected files highlighted with the active accent color even when they are marked reviewed.
The file tree navigation logic was moved into testable utilities with coverage for ordering, movement, and selection behavior.
How did you verify your code works?
Screenshots / recordings
Not included.
Checklist