feat(session): emit message.part.delta for tool-input-delta events#28815
Open
lexlian wants to merge 3 commits into
Open
feat(session): emit message.part.delta for tool-input-delta events#28815lexlian wants to merge 3 commits into
lexlian wants to merge 3 commits into
Conversation
Closes anomalyco#28800 The tool-input-delta case was a no-op with a comment claiming there was no consumer for state.raw. In reality, state.raw is consumed by the context breakdown component (token counting), subagent data serialization, and export output. This change follows the established reasoning-delta pattern: accumulate delta text into state.raw and emit updatePartDelta so downstream consumers receive real-time tool argument streaming events. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found two potentially related PRs that address similar tool streaming/delta event functionality: Potential Related PRs:
However, PR #28815 is the current PR, so it shouldn't be marked as a duplicate of itself. These two PRs above appear to address related but distinct aspects of tool streaming and should be reviewed to ensure there's no conflicting work or opportunity to consolidate the implementation. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28800
Type of change
What does this PR do?
Replaced the no-op
tool-input-deltahandler inpackages/opencode/src/session/processor.tswith the established delta pattern (mirrors the existingreasoning-deltahandler).The
tool-input-deltacase was silently dropping streaming tool argument fragments. The comment claimedstate.rawhad no consumer, but it is actually read by:session-context-breakdown.ts— token counting viapart.state.raw.lengthsubagent-data.ts— serializespart.state.rawexport.ts— includespart.state.rawin export outputChanges:
part.state.raw(guarded topendingstatus)session.updatePartDeltawithfield: "raw"so downstream consumers receive real-time updatesrole,toolStartLine,toolArgsLine,finishLinefrom test helpers to enable tool streaming testsHow did you verify your code works?
test/session/processor-effect.test.ts: tool argument streaming accumulates intostate.rawbun typecheckpasses (15/15 packages)bun test ./test/session/processor-effect.test.tspasses (14/14)Screenshots / recordings
N/A — internal session event behavior change.
Checklist