fix(opencode): respect system locale for time formatting#28805
Open
jeaEmri wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28804
Type of change
What does this PR do?
Bun ignores
LC_TIME/LANGenv vars whenundefinedis passed totoLocaleTimeString(), defaulting toen-US(12h AM/PM) regardless of system locale. This is a known Bun bug (oven-sh/bun#7386, open since Dec 2023).The fix adds a small helper that reads POSIX locale env vars (
LC_ALL>LC_TIME>LANG), converts the value to BCP-47 format (e.g.da_DK.UTF-8->da-DK), and passes it explicitly totoLocaleTimeString()andtoLocaleDateString(). Falls back toundefined(current behavior) when no env vars are set.How did you verify your code works?
bun test test/util/locale.test.ts-- 3 tests pass (24h locale, 12h locale, no-env fallback)LC_TIME=da_DK.UTF-8 bun -e "..."confirms08.xxoutput vs8:xx AMwithout the fixScreenshots / recordings
Not a UI change -- only affects time string formatting logic.
Checklist