fix(referral): show correct status for pending referral reward#28715
Open
PanAchy wants to merge 2 commits into
Open
fix(referral): show correct status for pending referral reward#28715PanAchy wants to merge 2 commits into
PanAchy wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28713
Type of change
What does this PR do?
The referral rewards UI showed "Subscribe to unlock" for two different situations:
This PR adds a separate i18n key for the pending-but-subscribed state, so the label correctly reads "Waiting for referral to subscribe" when the referrer is subscribed and the reward is
pending.Before:
After:
The button remains disabled for
pendingrewards. Only the label changes.Files changed:
packages/console/app/src/component/go-referral.tsx— updatedrewardActionKeylogicpackages/console/app/src/component/go-referral.reward-action.ts— new action key constantpackages/console/app/src/i18n/en.ts— new label stringHow did you verify your code works?
bun testinpackages/console/app— 7 tests pass, 0 fail.bun typecheckinpackages/console/app— no errors.reward.status !== "available" || !props.lite) is unchanged — pending rewards remain unclickable.Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist